Skip to content

Add some better sample env vars in settings.json#2066

Merged
aeisenberg merged 2 commits intomainfrom
aeisenberg/update-settingsjson
Feb 14, 2023
Merged

Add some better sample env vars in settings.json#2066
aeisenberg merged 2 commits intomainfrom
aeisenberg/update-settingsjson

Conversation

@aeisenberg
Copy link
Copy Markdown
Contributor

Small changes that will help with debugging custom codeql instances.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@aeisenberg aeisenberg requested a review from a team as a code owner February 10, 2023 23:55
Comment thread .vscode/settings.json Outdated
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .vscode/settings.json
"TZ": "UTC",

// Uncomment to set a custom path to a CodeQL checkout.
// "TEST_CODEQL_PATH": "../codeql",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this in launch.json?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the launch.json is used when you run the "Launch Integration Tests - With CLI" action using the "Run & Debug" panel of VSCode. These environment variables are instead used when you use the Jest runner to run tests. These are completely separate.

@aeisenberg aeisenberg merged commit 851a42f into main Feb 14, 2023
@aeisenberg aeisenberg deleted the aeisenberg/update-settingsjson branch February 14, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants